Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Util: More explicit EIP-1191 checksum usage discouraged note / Client: remove Rinkeby from CLI test matrix #1463

Merged
merged 2 commits into from Sep 10, 2021
Merged

Util: More explicit EIP-1191 checksum usage discouraged note / Client: remove Rinkeby from CLI test matrix #1463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af1e3ab
util: added more explicit note about providing a chainId to produce E…
holgerd77 Sep 9, 2021
20f221e
client: removed Rinkeby from client CLI runs being to unreliable ofte…
holgerd77 Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/client-build.yml
View file
Open in desktop
Expand Up @@ -49,7 +49,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
network: ['rinkeby', 'goerli']
network: ['goerli']
syncmode: ['full', 'light']
fail-fast: false
steps:
Expand Down
8 changes: 5 additions & 3 deletions packages/util/src/account.ts
View file
Open in desktop
Expand Up @@ -139,12 +139,14 @@ export const isValidAddress = function (hexAddress: string): boolean {
/**
* Returns a checksummed address.
*
* If a eip1191ChainId is provided, the chainId will be included in the checksum calculation. This
* If an eip1191ChainId is provided, the chainId will be included in the checksum calculation. This
* has the effect of checksummed addresses for one chain having invalid checksums for others.
* For more details see [EIP-1191](https://eips.ethereum.org/EIPS/eip-1191).
*
* WARNING: Checksums with and without the chainId will differ. As of 2019-06-26, the most commonly
* used variation in Ethereum was without the chainId. This may change in the future.
* WARNING: Checksums with and without the chainId will differ and the EIP-1191 checksum is not
* backwards compatible to the original widely adopted checksum format standard introduced in
* [EIP-55](https://eips.ethereum.org/EIPS/eip-55), so this will break in existing applications.
* Usage of this EIP is therefore discouraged unless you have a very targeted use case.
*/
export const toChecksumAddress = function (hexAddress: string, eip1191ChainId?: BNLike): string {
assertIsHexString(hexAddress)
Expand Down