Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EIP3074: AUTHCALL #1788

Closed
wants to merge 5 commits into from
Closed

Implement EIP3074: AUTHCALL #1788

wants to merge 5 commits into from

Conversation

jochem-brouwer
Copy link
Member

@ryanio
Copy link
Contributor

ryanio commented Mar 14, 2022

if there is no urgency to get this in a vm v5 release, then i wonder if we should target develop (vm v6) so we don't have to refactor the code from BN to bigint again

@jochem-brouwer
Copy link
Member Author

There is no urgency, will target develop

@jochem-brouwer
Copy link
Member Author

Right, before I continue should first rebase on develop.

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1788 (92d0de5) into master (b5d9fb0) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

Flag Coverage Δ
block 85.57% <ø> (ø)
blockchain 83.82% <ø> (+0.53%) ⬆️
client 75.82% <ø> (ø)
common 93.90% <ø> (ø)
devp2p 82.56% <ø> (-0.14%) ⬇️
ethash 90.76% <ø> (ø)
trie 80.27% <ø> (+0.24%) ⬆️
tx 88.20% <ø> (ø)
util 92.62% <ø> (ø)
vm 81.06% <75.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jochem-brouwer
Copy link
Member Author

Closed in favor of #1789

@holgerd77 holgerd77 deleted the eip3074-authcall branch March 15, 2022 08:55
@holgerd77
Copy link
Member

if there is no urgency to get this in a vm v5 release, then i wonder if we should target develop (vm v6) so we don't have to refactor the code from BN to bigint again

Yes, that makes a dramatic amount of sense 😜, hadn't thought about that either yet but we can very well start to do so. This will take some time to implement anyhow on these new bigger tasks, and v6 is finally not that far away any more (2-3 months I would say).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants