-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VM: Custom precompiles #1813
Merged
Merged
VM: Custom precompiles #1813
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
b9db2c7
vm/precompiles: do not export precompiles list
jochem-brouwer 899b943
vm: change precompile logic, use maps
jochem-brouwer 3296439
vm/tests: ensure these run
jochem-brouwer c83c188
vm: fixed custom precompile bugs
jochem-brouwer fc1a67d
vm: add custom precompile tests
jochem-brouwer 4752594
review, clean up, nits
ryanio 0b7a064
add _customPrecompiles to stateManager
ryanio da1f81b
vm: fixes custom opcodes
ryanio c168dd7
vm: re-export precompiles
jochem-brouwer 05cba44
vm: attempt to fix ci
jochem-brouwer a87ec6f
vm: experiment 2 to fix CI
jochem-brouwer 0a1dd86
vm: add public precompile method, remove experiment
jochem-brouwer e5697ef
vm: fix CI
jochem-brouwer 09ea3e4
vm: change function sig
jochem-brouwer f6a909e
Merge branch 'master' into custom-precompiles-bnjs
jochem-brouwer 45bac5d
vm: remove TODO
jochem-brouwer c85658e
vm: remove precompile logic from statemanager
jochem-brouwer 12e0f96
vm: remove customprecompiles from statemanager
jochem-brouwer 09856f8
Merge branch 'master' into custom-precompiles-bnjs
jochem-brouwer 66686c1
vm: use `precompiles` getter
jochem-brouwer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed this function sig, because it is incorrect anyways. Our internal logic calls this method, if
undefined
is returned we run a normal call, otherwise we run the precompile. (Also per the comment above)