Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VM: Custom precompiles #1813
VM: Custom precompiles #1813
Changes from 11 commits
b9db2c7
899b943
3296439
c83c188
fc1a67d
4752594
0b7a064
da1f81b
c168dd7
05cba44
a87ec6f
0a1dd86
e5697ef
09ea3e4
f6a909e
45bac5d
c85658e
12e0f96
09856f8
66686c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This very much feels like the wrong abstraction to me to bake the precompiles even more into
StateManager
, I guess this was suboptimal from the beginning to have thisgetActivePrecompiles
call in here.This becomes even more apparent regarding the upcoming
StateManager
extraction.Would it be a way to generally remove this
check1
and instead add the precompiles (e.g.) to the passed inaddressesRemoved
array? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, I don't know why I added this, it should not be there. I think I had in the original PR also the remark that we should probably wait for the state manager to be extracted.