DevP2P: add snap protocol #1883
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -4,9 +4,10 @@ import { EventEmitter } from 'events' | |||
| import { devp2pDebug } from '../util' | |||
| import { Peer, DISCONNECT_REASONS } from '../rlpx/peer' | |||
|
|
|||
| export enum EthProtocol { | |||
| export enum EthProtocol { // What does this represent? | |||
There was a problem hiding this comment.
This represents the protocol running on top of RLPx. Could probably just be renamed to Protocol, but that may conflict with the base class? RlpxProtocol could also work, but not sure if we want to rename/breaking change.
There was a problem hiding this comment.
We could rename this enum to ProtocolType?
|
Two tests for the SNAP protocol are proposed in #1893 |
|
Please do not merge here before last round of Relatively directly after the releases we actually should merge to clear the field for the latest |
|
@jochem-brouwer @holgerd77 this is good to merge in my opinion |
* Add tests for SNAP protocol * Fix linting issues * Remove unneeded switch block
|
Ok, then let's do it. 😃 |
Closes #1876
TODO: