Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockchain: align comment and code for getIteratorHead() #2126

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

ScottyPoi
Copy link
Contributor

Fixes

 Align comment and code in interface, see https://github.com/ethereumjs/ethereumjs-monorepo/pull/2069/files/48e08c9e6f6ad5956613d067b935aaf07788a23f#r938678329

From meta issue #2105.

Fixes misalignment.

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #2126 (4347f8b) into master (4347f8b) will not change coverage.
The diff coverage is n/a.

❗ Current head 4347f8b differs from pull request most recent head f6935cf. Consider uploading reports for the commit f6935cf to get more accurate results

Impacted file tree graph

Flag Coverage Δ
block 83.81% <0.00%> (ø)
blockchain 80.54% <0.00%> (ø)
client 77.06% <0.00%> (ø)
common 95.31% <0.00%> (ø)
devp2p 82.63% <0.00%> (ø)
ethash 90.81% <0.00%> (ø)
evm 40.72% <0.00%> (ø)
statemanager 84.55% <0.00%> (ø)
trie 81.02% <0.00%> (ø)
util 87.22% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77 holgerd77 force-pushed the blockchain-align-comment-and-code branch from 7a3955c to f6935cf Compare August 15, 2022 11:20
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will admin-merge since only code docs touched.

@holgerd77 holgerd77 merged commit 7b97a25 into master Aug 15, 2022
@holgerd77 holgerd77 deleted the blockchain-align-comment-and-code branch August 15, 2022 11:22
@acolytec3 acolytec3 mentioned this pull request Aug 22, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants