Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename consensusFormatValidationFlag #2209

Merged
merged 2 commits into from Aug 23, 2022
Merged

Conversation

acolytec3
Copy link
Contributor

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #2209 (2901172) into master (5dc3fd7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

Flag Coverage Δ
block 92.98% <100.00%> (ø)
blockchain 88.88% <ø> (ø)
client 87.00% <ø> (ø)
common 98.08% <ø> (ø)
devp2p 92.22% <ø> (-0.09%) ⬇️
ethash ∅ <ø> (∅)
evm 79.07% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 88.09% <ø> (ø)
trie 89.52% <ø> (ø)
tx 97.98% <ø> (ø)
util 92.33% <ø> (ø)
vm 85.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit ffe3402 into master Aug 23, 2022
@holgerd77 holgerd77 deleted the skipConsensusFormatValidation branch August 23, 2022 09:28
@holgerd77
Copy link
Member

Ah, short nit: can you please update the header description that you didn't remove the Kovan tests along this PR (just delete is sufficient)?

@acolytec3
Copy link
Contributor Author

I did remove them though. I'm not sure why they aren't showing up in the Files Changed section of the PR. 🤔

@holgerd77
Copy link
Member

I did remove them though. I'm not sure why they aren't showing up in the Files Changed section of the PR. 🤔

Ah, these tests were already removed in the Kovan PR #2206 🙂 .

@holgerd77
Copy link
Member

(maybe not do something like this before the related PR is merged, might also lead to somewhat dangerous situations (so, not dramatically dangerous, but just some file/update conflicts))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants