-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Kovan (EOL) / Common Mainnet Merge Default HF Fix #2206
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
Haha, |
Side note: I also thought about removing the I then decided to keep the |
@gabrocheleau finally, the real "success" is entering the repository, @ryanio will be reliefed. 😂 Nice, I guess there should be no reason to not merge this here (actually I will do)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Will admin-merge since technically reviewed by @gabrocheleau by continuing on the PR (and I in turn now reviewed the additional changes by Gabriel).
This PR removes support for Kovan which is EOL for quite some time and support for the only supporting client (Open Ethereum) has also ended.
I would still be inclined to keep Ropsten and Rinkeby since - while both networks are now deprecated - deprecation announcement is still pretty recent and both networks are still up and running and will likely still be used for testing purposes.
This is WIP, first push is for seeing if Kovan removal works for all packages on CI.
Will add some Common default HF update to the PR.