evm: add error which triggers if code size deposit exceeds the maximum size #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochem-brouwer
added
PR state: needs review
type: test all hardforks
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
holgerd77
force-pushed
the
evm-error-msgs
branch
from
7b350bf
to
ba549ee
Compare
|
Rebased this via UI. |
holgerd77
approved these changes
Aug 29, 2022
|
Late to the party, but thanks for this @jochem-brouwer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2065
Adds a new error type to EVM, which allows EVM consumers to figure out the difference between (Homestead or later) contract creation goes OOG, or if the deposited code is too large (exceeds maximum code size).
Checked other errors too, but did not find anything "weird" there.
CC @alcuadrado