Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra computation #2276

Merged
merged 2 commits into from Sep 11, 2022
Merged

Remove extra computation #2276

merged 2 commits into from Sep 11, 2022

Conversation

rodrigoherrerai
Copy link
Contributor

We extend the Memory inside of the write function, so it is unnecessary to do it here.

@rodrigoherrerai
Remove extra computation
8d92970 
We extend the Memory inside of the write function, so it is unnecessary to do it here.
@codecov
Copy link

codecov bot commented Sep 9, 2022 •
edited

Codecov Report

Merging #2276 (5b3b19b) into master (385f8ae) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 92.89% <ø> (ø)
blockchain 88.47% <ø> (ø)
client 86.95% <ø> (ø)
common 98.09% <ø> (ø)
devp2p 92.37% <ø> (-0.03%) ⬇️
ethash ∅ <ø> (∅)
evm 79.23% <ø> (-0.02%) ⬇️
rlp ?
statemanager 88.47% <ø> (ø)
trie 90.23% <ø> (+0.21%) ⬆️
tx 97.98% <ø> (ø)
util 91.67% <ø> (ø)
vm 85.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabrocheleau
Copy link
Contributor

Looks good to me!

@gabrocheleau gabrocheleau merged commit 295deaa into ethereumjs:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrocheleau gabrocheleau gabrocheleau approved these changes

Assignees
No one assigned
Labels
package: evm PR state: needs review type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rodrigoherrerai @gabrocheleau @holgerd77