Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude sim from client unit tests #2447

Merged
merged 3 commits into from
Dec 13, 2022
Merged

Conversation

acolytec3
Copy link
Contributor

Excludes sim directory from client tests since this isn't really a unit test but an integrated end-to-end test for validating experimental hardforks.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #2447 (8854778) into master (c1bf118) will decrease coverage by 4.18%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block ?
blockchain ?
client 87.56% <ø> (?)
common 98.08% <ø> (ø)
devp2p ?
ethash ?
evm 79.73% <ø> (?)
rlp ?
statemanager ?
trie ?
util ?
vm 85.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@g11tech g11tech merged commit 7e77b0f into master Dec 13, 2022
@holgerd77 holgerd77 deleted the update-client-test-scripts branch March 2, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants