Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While researching #2436, I encountered what I think are a couple of minor logic bugs:
miner
starts in the client, if yourcommon
instance's consensus is set topow
, it errors trying to access the PoA consensus algorithm's subproperty ofperiod
since theconsensusConfig
object in thecommon._chainParams
is undefined for PoW (this would presumably result in the same error for PoS). This resolve by just returning an empty object{}
if no configuration parameters are defined.cli
in lines 588 - 591. The error should occur in any scenario where we provide custom genesis parameters and also pass in eithernetwork
ornetworkId
since those tell thecommon
constructor to pull in predefined network genesis parameters.