Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: add eip option to GethConfigOpts #2469

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

gabrocheleau
Copy link
Contributor

This adds the EIP option to the GethConfigOpts. This change makes the workflow a bit easier for verkle trees work (can set directly the EIPs with the Common.fromGethConfig helper instead of using .setEIPs in a second step) so I'm extracting this in a separate PR. I think this could also be useful for further testnet work.

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #2469 (ca45a7d) into master (572d782) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 89.57% <ø> (ø)
blockchain 90.04% <ø> (ø)
client 87.82% <ø> (ø)
common 95.89% <100.00%> (+<0.01%) ⬆️
devp2p 91.70% <ø> (+0.19%) ⬆️
ethash ∅ <ø> (∅)
evm 79.73% <ø> (ø)
rlp ?
statemanager 89.61% <ø> (ø)
trie 90.36% <ø> (ø)
tx 97.80% <ø> (ø)
util 84.74% <ø> (ø)
vm 85.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@ScottyPoi ScottyPoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrocheleau gabrocheleau merged commit e8b87e3 into master Jan 4, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Jan 4, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 EthereumJS Contributor:

GitPOAP: 2023 EthereumJS Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@holgerd77 holgerd77 deleted the common/from-geth-genesis-eips branch January 4, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants