Devp2p Improvements and Clean-Ups / Client ID Integration #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerd77
force-pushed
the
devp2p-improvements
branch
from
b817bcd
to
c4b4529
Compare
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
g11tech
reviewed
Feb 20, 2023
| // Filter out snap because we can't yet provide snap endpoints to the peers | ||
| // TODO: Remove when we can also serve snap requests from other peers | ||
| .filter((c) => c.name !== 'snap') | ||
| .map((c) => `${c.name}${c.version}`) | ||
| .join(',')}` | ||
| .join(',')} clientId=${this._clientId}` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly picking up things from #2535 (accidental merge)
This PR does the following:
Ready for review and merge, would be nice to still have this included in the releases since the client ID update is a somewhat prominent change.