Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert ssz version to fix replaceAll error #2555

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Revert ssz version to fix replaceAll error #2555

merged 2 commits into from
Feb 27, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Feb 27, 2023 •
edited
Loading

@g11tech g11tech changed the title Fix ssz replace all Revert ssz version to fix replaceAll error Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023 •
edited
Loading

Codecov Report

Merging #2555 (f7510ef) into master (61e32b3) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.13% <ø> (ø)
blockchain 90.40% <ø> (ø)
client 87.70% <ø> (ø)
common 95.82% <ø> (ø)
devp2p 91.78% <ø> (-0.20%) ⬇️
ethash ∅ <ø> (∅)
evm 83.36% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 89.61% <ø> (ø)
trie 90.36% <ø> (ø)
tx 93.72% <ø> (ø)
util 84.50% <ø> (ø)
vm 83.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

holgerd77
holgerd77 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 25f5b67 into master Feb 27, 2023
@holgerd77 holgerd77 deleted the fix-ssz-replaceall branch February 27, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: util PR state: needs review type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

field.replaceAll is not a function error with recent versions
2 participants
@g11tech @holgerd77