Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ethereum-cryptography from 1.2 to 2.0 #2641

Merged
merged 1 commit into from Apr 14, 2023
Merged

Update ethereum-cryptography from 1.2 to 2.0 #2641

merged 1 commit into from Apr 14, 2023

Conversation

paulmillr
Copy link
Member

@paulmillr paulmillr commented Apr 14, 2023 •
edited

@codecov
Copy link

codecov bot commented Apr 14, 2023 •
edited

Codecov Report

Merging #2641 (b2fbb23) into master (efc4487) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.18% <ø> (ø)
blockchain 90.40% <ø> (ø)
client 87.12% <ø> (ø)
common 95.74% <ø> (ø)
devp2p 91.92% <100.00%> (+0.21%) ⬆️
ethash ∅ <ø> (∅)
evm 79.39% <ø> (ø)
statemanager 89.61% <ø> (ø)
trie 91.00% <ø> (+0.64%) ⬆️
tx 94.43% <ø> (ø)
util 85.19% <100.00%> (+0.02%) ⬆️
vm 84.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

holgerd77
holgerd77 approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cool, thanks!

@holgerd77 holgerd77 merged commit b4b1f82 into master Apr 14, 2023
39 checks passed
@gitpoap-bot
Copy link

gitpoap-bot bot commented Apr 14, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 EthereumJS Contributor:

GitPOAP: 2023 EthereumJS Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@holgerd77 holgerd77 deleted the e-c2 branch April 14, 2023 13:45
@Aniket-Engg Aniket-Engg mentioned this pull request Apr 24, 2023
Closed
acolytec3 pushed a commit that referenced this pull request May 12, 2023
@paulmillr @acolytec3
Update ethereum-cryptography from 1.2 to 2.0 (#2641)
19cfe05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: block package: blockchain package: client package: devp2p package: ethash package: evm package: statemanager package: trie package: tx package: util package: vm PR state: needs review type: maintenance type: security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulmillr @holgerd77