evm: Fix the gasCost logs in op code trace #2686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While matching op code trace of ethereumjs with the geth it was observed that ethereumjs's gasCost logs were incorrect w.r.t the actual gas used by the opcode.
This was happening because the dynamicFee should be the one to be logged which is the actual gas consumed by the opcode
Post this the gasCost mismatch diff with geth greatly reduced and the
0
gasCost entries disappeared from the trace