client: add shouldOverrideBuilder flag for getPayloadV3 #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g11tech
force-pushed
the
override-builder
branch
from
d1aec7b
to
fdf9884
Compare
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
| // ethereumjs doesnot provide any transaction censoring detection (yet) to suggest | ||
| // overriding builder/mev-boost blocks | ||
| const shouldOverrideBuilder = false | ||
| return { executionPayload, blockValue: bigIntToHex(value), blobsBundle, shouldOverrideBuilder } |
There was a problem hiding this comment.
As far as I can see, this does not do anything except return false? (Is this part of some spec?)
There was a problem hiding this comment.
see the comment on the top:
since we don't have any transaction censoring detection features,, we just return it as false (which is what is recommended to be returned if an EL doesn't has such features so the CL can choose builder/mev-boost block if it wants to)
g11tech
force-pushed
the
override-builder
branch
from
fdf9884
to
0e84706
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for devnet-8