common: add forkHash tests #2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
holgerd77
approved these changes
Aug 15, 2023
| const required = ['config', 'difficulty', 'gasLimit', 'nonce', 'alloc'] | ||
| if (required.some((field) => !(field in json))) { | ||
| const missingField = required.filter((field) => !(field in json)) | ||
| throw new Error(`Invalid format, expected geth genesis field "${missingField}" missing`) |
There was a problem hiding this comment.
Ugh. That was an urgent one. 🤯
("hey, you dumb user, you are missing a field here, but I won't tell you what it is!" 😂)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
noncefield to required Geth fields (otherwise one gets a non-descriptive error)