Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: update the shanghai hf schedule for holesky #2989

Merged
merged 1 commit into from
Aug 24, 2023
Merged

common: update the shanghai hf schedule for holesky #2989

merged 1 commit into from
Aug 24, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Aug 24, 2023

@g11tech g11tech added PR state: merge ready package: common target: master Work to be done towards master branch labels Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023 •
edited
Loading

Codecov Report

Merging #2989 (9450faa) into master (490b7a1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.66% <ø> (ø)
blockchain 92.58% <ø> (ø)
client 87.35% <ø> (ø)
common 98.61% <100.00%> (ø)
ethash ?
evm 70.43% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 84.43% <ø> (ø)
trie 89.82% <ø> (-0.25%) ⬇️
tx 95.97% <ø> (ø)
util 86.78% <ø> (ø)
vm 79.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

holgerd77
holgerd77 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 35ec012 into master Aug 24, 2023
42 checks passed
@holgerd77 holgerd77 deleted the g11tech/update-holesky-shanghai branch August 24, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: common PR state: merge ready target: master Work to be done towards master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g11tech @holgerd77