Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evm/vm: ensure backwards compatability reportPreimages #3298

Merged
merged 1 commit into from
Mar 1, 2024
Merged

evm/vm: ensure backwards compatability reportPreimages #3298

merged 1 commit into from
Mar 1, 2024

Conversation

jochem-brouwer
Copy link
Member

This PR guards startReportingPreimages of EVM

This is OK because:

  • The only way this is called is within VM reportPreimages -> therefore, we already assume that startReportingPreimages is available

@codecov Codecov
Copy link

codecov bot commented Mar 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.89%. Comparing base (f01264c) to head (74849e9).

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.34% <ø> (ø)
blockchain 91.61% <ø> (ø)
client 84.77% <ø> (ø)
common 98.25% <ø> (ø)
devp2p 82.12% <ø> (ø)
ethash ∅ <ø> (∅)
evm 74.25% <ø> (ø)
genesis 99.98% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 77.00% <ø> (ø)
trie 89.28% <ø> (-0.24%) ⬇️
tx 95.45% <ø> (ø)
util 89.13% <ø> (ø)
vm 79.62% <50.00%> (ø)
wallet 88.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

holgerd77
holgerd77 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit b3c8c28 into master Mar 1, 2024
45 of 46 checks passed
@holgerd77 holgerd77 deleted the fixup-releases-preimage branch March 1, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: evm package: vm PR state: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jochem-brouwer @holgerd77