Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blockhash opfn #381

Merged
merged 1 commit into from Nov 6, 2018
Merged

Fix blockhash opfn #381

merged 1 commit into from Nov 6, 2018

Conversation

mattdean-digicatapult
Copy link
Contributor

This fixes the BLOCKHASH opcode which is essentially broken. Fixes the following blockchain tests:

  • randomStatetest218BC
  • randomStatetest240BC
  • randomStatetest255BC
  • randomStatetest331BC
  • randomStatetest34BC
  • randomStatetest35BC
  • randomStatetest403BC
  • randomStatetest431BC
  • randomStatetest432BC
  • randomStatetest598BC
  • randomStatetest65BC
  • BLOCKHASH_Bounds
  • blockhashNonConstArg
  • blockhashTests

@coveralls
Copy link

coveralls commented Nov 6, 2018

Coverage Status

Coverage decreased (-0.1%) to 91.076% when pulling 84a3303 on fix-blockhash-opcode into 383bd5d on master.

This fixes the `BLOCKHASH` opcode which is essentially broken. Fixes the following blockchain tests:
* randomStatetest218BC
* randomStatetest240BC
* randomStatetest255BC
* randomStatetest331BC
* randomStatetest34BC
* randomStatetest35BC
* randomStatetest403BC
* randomStatetest431BC
* randomStatetest432BC
* randomStatetest598BC
* randomStatetest65BC
* BLOCKHASH_Bounds
* blockhashNonConstArg
* blockhashTests
@holgerd77
Copy link
Member

Rebased this.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Matthew!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants