Only run Coveralls when token exists #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2018
|
Can you do work directly on the main repo? Then it gets possible that a reviewer can eventually directly rebase. |
Sure thing, I'll use the main repo for the smaller PRs. That said, I'm more than happy to rebase before merging. |
|
I think this also makes sense for the larger PRs, we often had the case that someone starts on a feature and then someone else is picking up on the work (due to time constraints of the other person e.g.). Or do you have got some more points on doing this from an own fork? |
|
I'm not picky. I can work out of the main repo for all PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #359
This PR updates the
coverallsnpm script to only run Coveralls when the auth token exists in the environment .I've also removed the unused Travis CI configuration since that's confusing.