Migrate runBlockchain to typescript #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerd77
approved these changes
May 24, 2019
|
Ah, the tests, ok. 😋 |
11 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "migration" is mostly just changing the filetype and annotating types with
any, so that we have alllib/files in ts, and can use stricter typescript config (no js allowed). A few things need fixing in future:ethereumjs-blockchaincauses browser tests to fail (due toutil.callbackify)runBlockchainshould be promisified. Currently the difficulty is inBlockchain.iterator, which acts as a generator (an unstable js feature)ethereumjs-blockhas not been migrated yet