Use complete typescript configs, fix linting/formatting errors #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging 47a2d0f into 244b4ac - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
holgerd77
approved these changes
May 24, 2019
There was a problem hiding this comment.
One comment about the missing docs script in package.json, otherwise looks good, scrolled through all the code once to make sure nothing has been compromised (not the case).
Will nevertheless approve - since you wrote that you will address docs next - eventually just re-add there.
| "format-fix": "ethereumjs-config-format-fix", | ||
| "prepublishOnly": "npm run lint && npm run build:dist && npm run testBuildIntegrity", | ||
| "build:dist": "tsc", | ||
| "build:docs": "documentation build ./lib/index.js ./lib/runBlockchain.js ./lib/runBlock.js ./lib/runTx.js ./lib/runCode.js ./lib/runCall.js --format md --shallow > ./docs/index.md", |
There was a problem hiding this comment.
The build:docs command has gotten lost, this is unintentional I suppose?
There was a problem hiding this comment.
Ah yeah, this was by mistake. I removed it to add the typedoc version (which I thought I had added 🤔). Will re-add in the documentation PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the massive diff, but there's no code change (apart from formatting and linting error fixes), so hopefully it shouldn't be as difficult.
Next I'll focus on documentation.