Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: propagate errors occuring in cache._flush #562

Merged
merged 2 commits into from Jul 26, 2019
Merged

fix: propagate errors occuring in cache._flush #562

merged 2 commits into from Jul 26, 2019

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Jul 25, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jul 25, 2019 •
edited

Coverage Status

Coverage increased (+0.005%) to 95.097% when pulling 616b907 on fix/cache-err-cb into 0ccb64f on master.

@alcuadrado
Copy link
Member

I don't know much about this part of the codebase, but it looks good. I checked the rest of the file, and all the calls to _trie's methods handle the errors now.

holgerd77
holgerd77 approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, review by @alcuadrado.

@holgerd77 holgerd77 merged commit e26585f into master Jul 26, 2019
@holgerd77 holgerd77 deleted the fix/cache-err-cb branch July 26, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@s1na @coveralls @alcuadrado @holgerd77 @evertonfraga