Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codeAddress to step event #651

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Add codeAddress to step event #651

merged 1 commit into from
Jan 15, 2020

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Jan 15, 2020

DELEGATECALL and CALLCODE call the code of contract B in the context of contract A. So that the environment's address is still A, but B's code is being executed. I need a reliable way of knowing which contract's code is being executed atm so I added codeAddress to the step event.

holgerd77
holgerd77 approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@s1na s1na merged commit f363377 into master Jan 15, 2020
@s1na s1na deleted the feat/code-address-step branch January 15, 2020 12:30
@evertonfraga evertonfraga mentioned this pull request May 5, 2020
Merged
@evertonfraga evertonfraga added this to the VM v5 milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
VM v5
Development

Successfully merging this pull request may close these issues.
3 participants
@s1na @holgerd77 @evertonfraga