Update blockchain readme example #836
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
| }, | ||
| (err) => console.log(err || 'Done.'), | ||
| ) | ||
| blockchain.iterator('i', (block) => { |
There was a problem hiding this comment.
Is this intended to leave the await here?
There was a problem hiding this comment.
Yes the await would be useful for awaiting until the iterator is finished before moving onto the next line of code but since there is none I thought it’d be okay (and then I’d have to wrap it in an inner async func since you can’t await from the top level). I didn’t actually test it but I think it’ll work like that! Please correct me if I’m wrong :)
There was a problem hiding this comment.
I guess another option could be to add a .then(() => { console.log('Done.') }).catch(console.error)
This PR updates the blockchain example in the readme after the changes in #833.
Note: the geth example may not be working anymore due to changes to the geth db structure (see #745), so we may want to consider using another example here.