Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

FakeTransaction - from defaults to null address #94

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Apr 11, 2018

if no from is specified, a signature failure error will be thrown when the tx.from is used

if no `from` is specified, a signature failure error will be thrown when the `tx.from` is used
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 98.78% when pulling b49d3ca on kumavis-patch-1 into b6a8975 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 98.78% when pulling b49d3ca on kumavis-patch-1 into b6a8975 on master.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense.

@holgerd77 holgerd77 merged commit 6ea5b50 into master Apr 11, 2018
@holgerd77 holgerd77 deleted the kumavis-patch-1 branch April 11, 2018 11:47
holgerd77 added a commit that referenced this pull request Jun 29, 2018
holgerd77 added a commit that referenced this pull request Jul 2, 2018
Fix Fake transaction hash creation (revert PR #94)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants