Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Update keccak to the latest version 馃殌 #168

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Dec 20, 2018

The dependency keccak was updated from 1.4.0 to 2.0.0.

This version is not covered by your current version range.

If you don鈥檛 accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Release Notes for v2.0.0
  • use optimized implementations from XKCP (#8)
  • require node >= 6.0.0
Commits

The new version differs by 4 commits.

  • bce5b58 2.0.0
  • a7e7b02 use optimized implementations from XKCP (#8)
  • 09d59ee .travis.yml: Update Node versions (#9)
  • 2ac8fe7 benchmarks: Update 'sha3' to 2.0.0 (#7)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don鈥檛 help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 馃尨

@coveralls
Copy link

coveralls commented Dec 20, 2018

Coverage Status

Coverage remained the same at 99.336% when pulling 1014a03 on greenkeeper/keccak-2.0.0 into 0ddaed8 on master.

@MrRefactoring
Copy link

MrRefactoring commented Aug 6, 2019

Please add this to master. Not build to node v12 without it

@holgerd77
Copy link
Member

@s1na Will make this a non-blocking request to you: I would merge this once CI pass. If you have objections or reservations bumping the version here let me know. Would otherwise take this into the next minor release we discussed.

Side note: kept the bn.js version to 4.11.x for now - since there are currently no types yet for 5.0.0. Wasn't sure though if this should be a blocking reason for a version update.

@s1na
Copy link
Contributor

s1na commented Nov 5, 2019

Would otherwise take this into the next minor release we discussed.

Yeah I think that's fine.

The CI tests are passing now, I'll merge

@s1na s1na merged commit f158d29 into master Nov 5, 2019
@s1na s1na deleted the greenkeeper/keccak-2.0.0 branch November 5, 2019 13:05
@holgerd77
Copy link
Member

@MrRefactoring That's very gracious to give a heart on this after having asked for a merge 3 months ago. 馃槢

@MrRefactoring
Copy link

Thanks guys! This is part of the updates I need!

@alcuadrado alcuadrado mentioned this pull request Nov 6, 2019
@alcuadrado
Copy link
Member

Do you mind sharing what other upgrades you need, @MrRefactoring ? Thanks!

evertonfraga added a commit that referenced this pull request Nov 6, 2019
@MrRefactoring
Copy link

I'm afraid it took a long time to remember what exactly I needed to update. I'm sorry

@alcuadrado
Copy link
Member

Don't worry @MrRefactoring. Feel free to open an issue if you remember any of them. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants