Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istanbul Draft EIP-1108 Support #540

Merged
merged 4 commits into from
Jun 6, 2019
Merged

Conversation

holgerd77
Copy link
Member

@holgerd77 holgerd77 commented Jun 5, 2019

Addresses #539.

WIP, first push to run the tests against ethereumjs-common v1.2.1.

I think for the time of Istanbul development we should fix the common dependency version (have done this here) to have more predictable Istanbul behavior since EIPs might change and we don't want to do major version bump for every change here over on the Common side.

@coveralls
Copy link

coveralls commented Jun 5, 2019

Coverage Status

Coverage remained the same at 94.997% when pulling adcfc76 on istanbul-draft-eip1108-support into 5d4fa87 on master.

@holgerd77
Copy link
Member Author

Ok, this is now ready for review. I've added some API tests for the precompiles touched in a separate istanbul/ folder, this can serve as some directory structure also for other EIP tests.

I also added these tests as regular precompile tests running against Petersburg within the normal test directory structure, should be helpful also for further precompile testing and development.

Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those tests look great, thanks Holger 😄

@holgerd77
Copy link
Member Author

Thanks, I can really need some kind words the few times I'm doing something directly productive! 😋

@holgerd77 holgerd77 merged commit b1ef0a6 into master Jun 6, 2019
@holgerd77 holgerd77 deleted the istanbul-draft-eip1108-support branch June 6, 2019 09:22
@holgerd77 holgerd77 mentioned this pull request Jul 31, 2019
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants