Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on crypto #63

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Remove dependency on crypto #63

merged 1 commit into from
Sep 24, 2018

Conversation

axic
Copy link
Member

@axic axic commented Jul 28, 2018 •
edited
Loading

Closes #18.

Fixes #8.

@axic axic mentioned this pull request Jul 28, 2018
Closed
@coveralls
Copy link

coveralls commented Jul 28, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 88.502% when pulling 1d719ea on remove-crypto into 95683dd on master.

@jwerle
Copy link
Contributor

jwerle commented Aug 15, 2018

@holgerd77 anything holding this up? 🙃

jwasinger
jwasinger suggested changes Aug 15, 2018
View reviewed changes
Copy link
Contributor

@jwasinger jwasinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, not sure about this. The aim of this PR is to remove crypto as a whole right? Do we only need to remove it where randomBytes is used?

@holgerd77
Copy link
Member

@jwerle I have not deep enough insights here to give comments on this.

@holgerd77
Copy link
Member

Rebased this.

holgerd77
holgerd77 approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will use the comment from @jwerle as a review and approve/merge.

@holgerd77 holgerd77 merged commit 5735026 into master Sep 24, 2018
@holgerd77 holgerd77 deleted the remove-crypto branch September 24, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwasinger jwasinger jwasinger requested changes

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
PR state: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@axic @coveralls @jwerle @holgerd77 @jwasinger