New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: modify getTreeKeyHash
to use hashCommitment
#31
Conversation
Updated this PR to take the merged WASM path fix into account (needed a conflict resolution). |
gballet/go-ethereum#401 (comment) has been merged which unblocks this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kevaundray I'm assuming we need to do an updated release on this one, right? |
Yep! This is a breaking change for downstream |
And just to confirm my understanding, this also changes how the stems are computed so we should expect different outputs from |
Yep, exactly -- this changes getTreeKeyHash which is used by getTreeKey |
Supercedes #24
Once the go-ethereum PR has been merged, we can merge this