Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: modify getTreeKeyHash to use hashCommitment #31

Merged
merged 10 commits into from Apr 1, 2024

Conversation

kevaundray
Copy link
Collaborator

Supercedes #24

Once the go-ethereum PR has been merged, we can merge this

@kevaundray kevaundray changed the base branch from master to kw/postfix-wasm-path March 7, 2024 22:55
Base automatically changed from kw/postfix-wasm-path to master March 8, 2024 09:53
@holgerd77
Copy link
Member

Updated this PR to take the merged WASM path fix into account (needed a conflict resolution).

@kevaundray
Copy link
Collaborator Author

gballet/go-ethereum#401 (comment) has been merged which unblocks this PR

@kevaundray kevaundray marked this pull request as ready for review April 1, 2024 17:09
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3
Copy link
Contributor

@kevaundray I'm assuming we need to do an updated release on this one, right?

@acolytec3 acolytec3 merged commit 9d16a7b into master Apr 1, 2024
3 checks passed
@kevaundray
Copy link
Collaborator Author

@kevaundray I'm assuming we need to do an updated release on this one, right?

Yep! This is a breaking change for downstream

@acolytec3
Copy link
Contributor

And just to confirm my understanding, this also changes how the stems are computed so we should expect different outputs from getTreeKey, right? Just want to make sure since I need to update the tests for the downstream code in @ethereumjs/verkle

@acolytec3 acolytec3 mentioned this pull request Apr 2, 2024
@kevaundray
Copy link
Collaborator Author

And just to confirm my understanding, this also changes how the stems are computed so we should expect different outputs from getTreeKey, right? Just want to make sure since I need to update the tests for the downstream code in @ethereumjs/verkle

Yep, exactly -- this changes getTreeKeyHash which is used by getTreeKey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants