trie/verkle: change tree key generation #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
commented
Mar 6, 2024
| // The output of Byte() is big engian for banderwagon. This | ||
| // introduces an imbalance in the tree, because hashes are | ||
| // elements of a 253-bit field. This means more than half the | ||
| // tree would be empty. To avoid this problem, use a little | ||
| // endian commitment and chop the MSB. | ||
| retb := evaluated.Bytes() | ||
| for i := 0; i < 16; i++ { | ||
| retb[31-i], retb[i] = retb[i], retb[31-i] | ||
| } | ||
| retb := verkle.HashPointToBytes(evaluated) |
There was a problem hiding this comment.
For more info: ethereum/go-verkle#428
kevaundray
approved these changes
Mar 6, 2024
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
pushed a commit
that referenced
this pull request
May 7, 2024
* trie/verkle: change tree key generation Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * update go-verkle Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
* trie/verkle: change tree key generation Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * update go-verkle Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
* trie/verkle: change tree key generation Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * update go-verkle Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
* trie/verkle: change tree key generation Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * update go-verkle Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how we transform a point to bytes to be used as a tree key.
Note: still in draft since it's waiting for a small PR merge in go-verkle, but it's ready for review.Note: we should merge this PR as soon as the target branch is ready for the new testnet.