Code cleanup

[doerfli]

No description provided.

[matthiaszimmermann]

feels strange that an isXYZ function does not return bool.
seems this is only used in

• ComponentOwnerService.archive(uint256 id)
• InstanceOperatorService.archive(uint256 id)

in both cases a sequence of 3 requires would feel more natural as the nested if statement.
please consider something like

function archive(...)
...
{
require(comonent_type==riskpool, "ERROR...NOT_RISKPOOL")
require(coponent_sate==..., "ERROR...TRANSITION_TO_ARCHIVED_STATE_INVALID")
require(bundle.unburnedBundles() == 0, "RISKPOOL_HAS_UNBURNT_BUNDLES")
..
}

or a modifier archivingAllowed ... with the same effect

[doerfli]

I had the same thought when looking at the code. But it seems i forgot to fix it ;-)
But the if is still required as the require is not for all components, but only archive.
Also not having it in poolcontroller would require adding a dependency to bundlecontroller to both ComponentOwnerService and InstanceOperatorService for checking the unburnedBundles. I also don't like that approach. maybe just rename the method from isArchivingAllowed to archivePreconditionCheck make its more understandable. Ill do that in a separate PR to be able to close this one now.