Throw exception instead of returning null for getDefaultProvider (#351).

ethers-io · Nov 21, 2018 · 31d3ee8 · 31d3ee8
1 parent 98143a8
commit 31d3ee8
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src.ts/ethers.ts b/src.ts/ethers.ts
@@ -33,8 +33,14 @@ import { ContractFunction, ContractTransaction, Event, EventFilter } from './con
 // Helper Functions
 
 function getDefaultProvider(network?: utils.Network | string): providers.BaseProvider {
-    let n = utils.getNetwork(network || 'homestead');
-    if (!n || !n._defaultProvider) { return null; }
+    if (network == null) { network = 'homestead'; }
+    let n = utils.getNetwork(network);
+    if (!n || !n._defaultProvider) {
+        errors.throwError('unsupported getDefaultProvider network', errors.UNSUPPORTED_OPERATION, {
+            operation: 'getDefaultProvider',
+            network: network
+        });
+    }
     return n._defaultProvider(providers);
 }