Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swip message to honey #21

Closed
wants to merge 88 commits into from
Closed

Swip message to honey #21

wants to merge 88 commits into from

Conversation

Eknir
Copy link
Contributor

@Eknir Eknir commented Aug 30, 2019

This SWIP proposes an on-chain oracle to resolve the price for any Swarm message type in honey

Daniel A. Nagy and others added 30 commits July 11, 2019 14:26
Template for all SWIPs
499a9a2
@nagydani
Close remark tag
7a95093
@zelig
Merge pull request #2 from nagydani/template
1b77d30 
Template for all SWIPs
@Eknir
Create swip-1.md
004acf6
@Eknir
Create swip-2.md
595fa43
@Eknir
Create swip-3.md
2a6d8df
@Eknir
Create swip-4.md
c79cbf4
@Eknir
included relevant diagrams
89dc575
@Eknir
Update swip-4
5fc087f 
Previously, swip-4 erroneously contained the contents of swip-3
@Eknir
Markdown styling issues updated
7c53465
@Eknir
Fixed markdown styling issue
00ce1fb
@Eknir
Fixed md styling issues, added authors
c2cb782
@Eknir
Fixed md styling issue
17cfdee
@Eknir
Style update, comments and rationale
5a6559b
@Eknir
Add files via upload
013f271
@Eknir
Add files via upload
5882e5b
@Eknir
Included reference to other SWIPs
68f53ee
@Eknir
rename diagram
91b8864
@Eknir
rename SWIP Diagram
38d64da
@Eknir
directory structure in assets, cross referencing
555ddb9
@Eknir
removed redundant images, rename
aaa4a6b
@Eknir
diagram referencing in text
6d9caa2
@Eknir
added rationale to MoneyToHoney
3ea545b
@Eknir
review cobordism
4001d00
@diegomasini
added technical section describing the existing code and potential im…
0362323 
…plementation
@diegomasini
Fixed path to diagrams. Added missing Handshake.svg diagram.
98e7afa
@diegomasini
fixed handshake diagram reference
fb6df58
@diegomasini
fixed handshake diagram reference
54494be
@diegomasini
fixed comment in SwarmPayments struct
8db50de
@diegomasini
removed unneeded text below general diagram
9ccaa4d
Eknir and others added 12 commits August 28, 2019 10:10
@Eknir
msgToHoney: clarified responsibilities of oracleContract and oracleWr…
3f90db1 
…apper
@Eknir
msgToHoney: clarification to example
fba0637
@Eknir
removed regular intervals
647d961
@Eknir
linked msgOracle smart-contracts
573e5b1
@Eknir
clarified responsibilities of the msgToHoneyContract / messageToHoney…
9b9e86f 
…Oracle
@Eknir
honeyToMoney: included last review comments
b9d8423
@Eknir
Merge pull request #15 from Eknir/msgToHoney_review
bc0d6ee 
msgToHoney: updated the oracle response structure, renaming, grammar-…
@vojtechsimetka
updated diagrams to be png and added sequence diagram
53e9cad
@Eknir
Merge pull request #19 from vojtechsimetka/SWIP-message_to_honey
25e5287 
SWIP-message_to_honey: Updated diagrams to be png and added sequence diagram
@Eknir
changed honey-prices to message-prices
0463730
@Eknir
updated date created
02d5194
@Eknir
updated links to other SWIPs
0444293
nagydani
nagydani reviewed Sep 3, 2019
View reviewed changes
Copy link
Collaborator

@nagydani nagydani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please assign the number #21 to this PR, it is well structured and clearly written. Perhaps, it might be with making the honey/gas analogy explicit.

diegomasini pushed a commit that referenced this pull request Sep 5, 2019
@Eknir
Merge pull request #21 from ethersphere/master
e15bb67 
Sync with ethersphere/master
nagydani
nagydani approved these changes Sep 9, 2019
View reviewed changes
Copy link
Collaborator

@nagydani nagydani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for Draft status.

@diegomasini diegomasini requested review from diegomasini, decanus and oskarth and removed request for diegomasini September 9, 2019 16:20
oskarth
oskarth reviewed Sep 26, 2019
View reviewed changes
Copy link

@oskarth oskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid! Need to give it some more thought before giving more constructive feedback.

Has any simulation / dry run / PoC of this been developed or considered?

SWIPs/swip-X.md
@@ -0,0 +1,54 @@
---
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover commit?

@Eknir Eknir mentioned this pull request Oct 22, 2019
Merged
@crtahlin crtahlin added the check-SWIP-status Check if the SWIP is still relevant and being pursued. label Jun 20, 2023
@crtahlin crtahlin closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarth oskarth oskarth left review comments

@nagydani nagydani nagydani approved these changes

@decanus decanus Awaiting requested review from decanus

Assignees
No one assigned
Labels
check-SWIP-status Check if the SWIP is still relevant and being pursued.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Eknir @nagydani @oskarth @crtahlin @zelig @diegomasini @vojtechsimetka @mortelli @holisticode