feat: parametric traffic gen #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nugaon
force-pushed
the
feat/parametric-traffic-gen
branch
from
bb0e4f8
to
eea6ea6
Compare
scripts/gen-traffic.js
Outdated
Comment on lines
98
to
106
| for(const incomingCheque of incomingCheques) { | ||
| const lastCashOut = await beeDebug.getLastCashoutAction(incomingCheque.peer) | ||
| if(lastCashOut.uncashedAmount > 0) { | ||
| uncashedCheques.push(incomingCheque) | ||
| } | ||
| } | ||
|
|
||
| beesUncashedCheques.push(uncashedCheques) | ||
| } |
There was a problem hiding this comment.
This can potentially take long as you process one async call at time (not probably a problem locally but if you want to use it on real network). My suggestion would be to rewrite this into a map that returns array of promises. Then you can just await on all of them with await Promise.all.
Then you could just reduce this to the amount of cheques per peer.
Comment on lines
+125
to
+127
| if(hosts.length === 0) { | ||
| hosts = [ 'http://localhost:1633;http://localhost:11635' ] | ||
| } |
There was a problem hiding this comment.
My personal preference would be to already parse it here and then pass it as array of objects. But I do acknowledge it's not necessary:
[
{ beeApi: ... , beeDebugApi: ... },
{ beeApi: ... , beeDebugApi: ... },
]There was a problem hiding this comment.
yeah, actually I planned to resolve it in genTrafficLoop function originally. I think it is in a great place there as it is now.
vojtechsimetka
approved these changes
May 21, 2021
Co-authored-by: Vojtech Simetka <vojtech@simetka.cz>
agazso
reviewed
May 21, 2021
* refactor: concurent promises * refactor: simplify lastCashOutPromises * refactor: raise timeout to get cheques sooner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traffic generation script had to be improved by passing the cheque numbers that is desired on a particular Bee node.
For that the traffic generation call structure changed to the following:
By that the script can exit from the infinite loop after the count of the incoming cheques on
BEE_DEBUG_URLreaches the givenMIN_CHEQUE_NUMBER. The random data will be generated onBEE_URLas it happened so far.it is the continuation of the #28 PR