refactor: traffic gen promise all #36
Conversation
nugaon
force-pushed
the
refactor/traffic-gen-promise-all
branch
from
1712170
to
40cd614
Compare
There was a problem hiding this comment.
Nevertheless, the scripts won't exit from the infinite loop ever, because it overloads the Bee node and won't show up any incoming cheques on the destination node unless you break the infinite loop.
Wow I wonder if there is some await missing so it just spams the bee nodes. If not, then I'd suggest to increase the sleep between uploads just to see how that will behave. I'm happy to jump on a pair programming session, so that we can report the findings to Bee devs.
| for(const [index, lastCashOut] of lastCashOuts.entries()) { | ||
| if(lastCashOut.uncashedAmount > 0) { | ||
| uncashedCheques.push(incomingCheque) | ||
| uncashedCheques.push(incomingCheques[index]) | ||
| } | ||
| } |
There was a problem hiding this comment.
Also suggesting one line which just stores the number of uncashed cheques (we don't really care about the amount, right? ).
const count = lastCashOuts.reduce((acc, {uncashedAmount}) => uncashedAmount > 0 ? acc +1 : acc, 0)There was a problem hiding this comment.
I would keep it as it is now for future request that requires some amount of debt from node, and it is quite simple now
with the prev setup in the base branch works, because with the gradual queries for cheques fills out this additional sleep time that it needs. I created this branch for investigate this issue, but it won't be merged until the Bee client can handle the cheque issuances on load. |
|
Long story short, because of the time-base settlement the cheques will issued a little later than before (~1-2 min) but actually they will be issued after a while, so everything seems fine regarding to this. |
|
I also raised the sleep time, because I noticed the cheques arrive earlier if the data upload is not continuous. |
* feat: parametric traffic generation * refactor: host input splitting Co-authored-by: Vojtech Simetka <vojtech@simetka.cz> * docs: update readme * refactor: typeo * refactor: traffic gen promise all (#36) * refactor: concurent promises * refactor: simplify lastCashOutPromises * refactor: raise timeout to get cheques sooner Co-authored-by: Vojtech Simetka <vojtech@simetka.cz>
As @vojtechsimetka correctly proposed, the cheque requests in traffic generation could happen concurently, that I made in this PR.
Nevertheless, the scripts won't exit from the infinite loop ever, because it overloads the Bee node and won't show up any incoming cheques on the destination node unless you break the infinite loop.
I guess it can be something related to how Bee handles its ongoing processes, but it seems like if the node processes and pushes continuously chunks, it cannot issue cheques.