localstore, shed: persist stamps #1116

acud · 2021-01-16T08:39:25Z

#933

zelig

LGTM

acud · 2021-01-16T21:19:57Z

/run beekeeper

acud · 2021-01-17T19:17:19Z

some simplification is due in terms of the chunk type. will solicit a review once that's done

janos · 2021-01-18T11:38:12Z

pkg/localstore/localstore.go

@@ -214,7 +215,8 @@ func New(path string, baseKey []byte, o *Options, logger logging.Logger) (db *DB
 	}

 	// Index storing actual chunk address, data and bin id.
-	db.retrievalDataIndex, err = db.shed.NewIndex("Address->StoreTimestamp|BinID|Data", shed.IndexFuncs{
+	headerSize := 16 + postage.StampSize
+	db.retrievalDataIndex, err = db.shed.NewIndex("Address->StoreTimestamp|BinID|BatchID|Sig|Data", shed.IndexFuncs{


Should this be BinID|StoreTimestamp|Stamp|Data? Stamp does consist of batch id and sig, but that is internal to the stamp, not reflected in this encoding.

I think that we would need a migration for this encoding change. The Index name is changed and the required encoding change is such that a simple index rename is not possible.

We will indeed need a migration (or at least a policy on how to deal with this), but since some minor details might still change in localstore we will add this to the list of tasks that need be addressed before this goes to master 👍

postage: new pkg for postage stamps, uploader stamping (#890) * postage: new pkg for postage stamps, uploader stamping * postage: amount->value, blockNumber big.Int-> uint64, stamp only has batch ID, not Batch * postage: fix godoc and copyright * postage, swarm: - swarm.Stamp as an interface - add postage/testing for mock Stamps - fix Stamp MarshalBinary to allow nil batch id and signature - add StampSize const * postage: heed review feedback Co-authored-by: acud <12988138+acud@users.noreply.github.com> Storage incentives: add stamper putter to api Postage BatchStore and BatchService (#1070) Co-authored-by: zelig <viktor.tron@gmail.com> add normalisedBalance to updater interface (#1108) make value the normalised balance (#1111) postage: add event listener (#1099) Wire up postage stamp syncing (#1114) localstore, shed: persist stamps (#1116) add --postage to beeinfra.sh setup pullsync, pushsync: add postage stamps (#1117) postage: add create endpoint (#1142) retrieve erc20 address from postage contract (#1169) postage: check balance before attempting stamp creation (#1177) postage: fix bucket depth (#1178) api: use hex encoding in postage api (#1179) increase page size (#1182) postage: handle bucket depth error in api (#1183) localstore: attach stamp to outgoing chunk (#1192) update postage stamp contract addresses for new token (#1208) batchstore: reserve (#1262) * postage/batchstore: reserve logic Co-authored-by: acud <12988138+acud@users.noreply.github.com> stamp support in storage and protocols (#1321) api: endpoints for stamp issuers (#1535) retrieval: add stamps (#1552) localstore reserve logic (#1322) Co-authored-by: acud <12988138+acud@users.noreply.github.com>

bee-runner bot added the pull-request label Jan 16, 2021

acud changed the base branch from master to storage-incentives January 16, 2021 08:39

acud marked this pull request as draft January 16, 2021 08:55

acud force-pushed the persist-stamps branch from 7042e8e to b7548fe Compare January 16, 2021 09:33

acud self-assigned this Jan 16, 2021

acud force-pushed the persist-stamps branch from 5ef3457 to 7bfbf5c Compare January 16, 2021 10:09

localstore, shed: persist postage stamps

08d9c9a

acud force-pushed the persist-stamps branch from 8840fb2 to 08d9c9a Compare January 16, 2021 10:15

acud marked this pull request as ready for review January 16, 2021 10:30

acud requested review from zelig, janos and ralph-pichler January 16, 2021 10:30

acud added the ready for review The PR is ready to be reviewed label Jan 16, 2021

zelig approved these changes Jan 16, 2021

View reviewed changes

acud added 2 commits January 16, 2021 13:29

add fallback value for batch service

94187ea

unbreak integration tests

ce860cb

acud force-pushed the persist-stamps branch from af28385 to ce860cb Compare January 16, 2021 12:46

acud removed request for janos and ralph-pichler January 17, 2021 19:16

acud removed the ready for review The PR is ready to be reviewed label Jan 17, 2021

acud added 3 commits January 18, 2021 09:49

change stamp on chunk type to be a byte slice

0ba7711

test build

b22b97e

simplify

00854d4

acud added the ready for review The PR is ready to be reviewed label Jan 18, 2021

acud requested a review from janos January 18, 2021 10:19

janos reviewed Jan 18, 2021

View reviewed changes

address comments

80c33c9

janos approved these changes Jan 18, 2021

View reviewed changes

acud merged commit 4ee7a60 into storage-incentives Jan 18, 2021

acud deleted the persist-stamps branch January 18, 2021 17:14

acud added a commit that referenced this pull request Jan 27, 2021

localstore, shed: persist stamps (#1116)

16a7bdc

acud added a commit that referenced this pull request Feb 1, 2021

localstore, shed: persist stamps (#1116)

92c4c1e

acud added a commit that referenced this pull request Feb 3, 2021

localstore, shed: persist stamps (#1116)

a9193eb

acud added a commit that referenced this pull request Feb 9, 2021

localstore, shed: persist stamps (#1116)

616e61c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

localstore, shed: persist stamps #1116

localstore, shed: persist stamps #1116

acud commented Jan 16, 2021

zelig left a comment

acud commented Jan 16, 2021

acud commented Jan 17, 2021 •

edited

Loading

janos Jan 18, 2021

acud Jan 18, 2021

localstore, shed: persist stamps #1116

localstore, shed: persist stamps #1116

Conversation

acud commented Jan 16, 2021

zelig left a comment

Choose a reason for hiding this comment

acud commented Jan 16, 2021

acud commented Jan 17, 2021 • edited Loading

janos Jan 18, 2021

Choose a reason for hiding this comment

acud Jan 18, 2021

Choose a reason for hiding this comment

acud commented Jan 17, 2021 •

edited

Loading