api: use hex encoding in postage api #1179

ralph-pichler · 2021-01-29T10:24:07Z

api returned base64 encoded id instead of hex.

acud · 2021-01-29T12:48:39Z

pkg/api/postage.go

 	"github.com/gorilla/mux"
 )

 type postageCreateResponse struct {
-	BatchID []byte `json:"batchID"`
+	BatchID swarm.Address `json:"batchID"`


not sure we'd actually want to use this type here, strictly speaking, this isn't an address

i only used this because it has the right encoding. []byte uses base64 unfortunately. what type would you suggest?

[]byte and implement json.Marshaler?

you cannot implement anything on []byte. I made a custom type for this field.

i meant the define the JSON marshaler on postageCreateResponse

postage: new pkg for postage stamps, uploader stamping (#890) * postage: new pkg for postage stamps, uploader stamping * postage: amount->value, blockNumber big.Int-> uint64, stamp only has batch ID, not Batch * postage: fix godoc and copyright * postage, swarm: - swarm.Stamp as an interface - add postage/testing for mock Stamps - fix Stamp MarshalBinary to allow nil batch id and signature - add StampSize const * postage: heed review feedback Co-authored-by: acud <12988138+acud@users.noreply.github.com> Storage incentives: add stamper putter to api Postage BatchStore and BatchService (#1070) Co-authored-by: zelig <viktor.tron@gmail.com> add normalisedBalance to updater interface (#1108) make value the normalised balance (#1111) postage: add event listener (#1099) Wire up postage stamp syncing (#1114) localstore, shed: persist stamps (#1116) add --postage to beeinfra.sh setup pullsync, pushsync: add postage stamps (#1117) postage: add create endpoint (#1142) retrieve erc20 address from postage contract (#1169) postage: check balance before attempting stamp creation (#1177) postage: fix bucket depth (#1178) api: use hex encoding in postage api (#1179) increase page size (#1182) postage: handle bucket depth error in api (#1183) localstore: attach stamp to outgoing chunk (#1192) update postage stamp contract addresses for new token (#1208) batchstore: reserve (#1262) * postage/batchstore: reserve logic Co-authored-by: acud <12988138+acud@users.noreply.github.com> stamp support in storage and protocols (#1321) api: endpoints for stamp issuers (#1535) retrieval: add stamps (#1552) localstore reserve logic (#1322) Co-authored-by: acud <12988138+acud@users.noreply.github.com>

bee-runner bot added the pull-request label Jan 29, 2021

ralph-pichler marked this pull request as ready for review January 29, 2021 10:34

ralph-pichler changed the title ~~postage: use hex encoding in postage api~~ api: use hex encoding in postage api Jan 29, 2021

acud reviewed Jan 29, 2021

View reviewed changes

postage: use hex encoding in postage api

70fede6

ralph-pichler force-pushed the fix-postage-api branch from 3e101a9 to 70fede6 Compare January 29, 2021 13:56

acud approved these changes Jan 29, 2021

View reviewed changes

ralph-pichler added 2 commits February 1, 2021 09:40

use custom batchId type

4cb4da1

linting

76935e5

acud approved these changes Feb 1, 2021

View reviewed changes

remove unmarshall

3510a2e

ralph-pichler merged commit 039d4ab into storage-incentives Feb 1, 2021

ralph-pichler deleted the fix-postage-api branch February 1, 2021 10:14

acud pushed a commit that referenced this pull request Feb 1, 2021

api: use hex encoding in postage api (#1179)

a1094ff

acud pushed a commit that referenced this pull request Feb 3, 2021

api: use hex encoding in postage api (#1179)

22684e6

acud pushed a commit that referenced this pull request Feb 9, 2021

api: use hex encoding in postage api (#1179)

e01c3cd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

api: use hex encoding in postage api #1179

api: use hex encoding in postage api #1179

ralph-pichler commented Jan 29, 2021

acud Jan 29, 2021

ralph-pichler Jan 29, 2021 •

edited

Loading

acud Jan 29, 2021

ralph-pichler Feb 1, 2021

acud Feb 1, 2021

api: use hex encoding in postage api #1179

api: use hex encoding in postage api #1179

Conversation

ralph-pichler commented Jan 29, 2021

acud Jan 29, 2021

Choose a reason for hiding this comment

ralph-pichler Jan 29, 2021 • edited Loading

Choose a reason for hiding this comment

acud Jan 29, 2021

Choose a reason for hiding this comment

ralph-pichler Feb 1, 2021

Choose a reason for hiding this comment

acud Feb 1, 2021

Choose a reason for hiding this comment

ralph-pichler Jan 29, 2021 •

edited

Loading