-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: marshal bigint as string #1735
Conversation
this will most likely require changes to the beekeeper tests |
Yeah, you are right. I will try to make those adjustments, but not sure if I have sufficient knowledge for this 😅 |
I tried to put something here ethersphere/beekeeper#148 but not sure if it is working as I can't run it locally unfortunately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 13 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AuHau)
72a91dc
to
81ae812
Compare
Closes #1561 and closes #756.
It creates BigInt struct that is applied only to API layer, while all internal calculations are still kept in big.Int.
It introduces breaking changes for several DebugAPI endpoints where amounts are converted from numbers to strings.
Succeeds #1627
This change is