Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: marshal bigint as string #1735

Merged
merged 8 commits into from
Jun 9, 2021
Merged

fix: marshal bigint as string #1735

merged 8 commits into from
Jun 9, 2021

Conversation

AuHau
Copy link
Contributor

@AuHau AuHau commented May 17, 2021

Closes #1561 and closes #756.

It creates BigInt struct that is applied only to API layer, while all internal calculations are still kept in big.Int.

It introduces breaking changes for several DebugAPI endpoints where amounts are converted from numbers to strings.

Succeeds #1627

This change is Reviewable

@ralph-pichler
Copy link
Member

this will most likely require changes to the beekeeper tests

@AuHau
Copy link
Contributor Author

AuHau commented May 17, 2021

Yeah, you are right. I will try to make those adjustments, but not sure if I have sufficient knowledge for this 😅

@AuHau
Copy link
Contributor Author

AuHau commented May 17, 2021

I tried to put something here ethersphere/beekeeper#148 but not sure if it is working as I can't run it locally unfortunately.

Copy link
Member

@zelig zelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AuHau)

@AuHau AuHau force-pushed the stringify-bigint branch 2 times, most recently from 72a91dc to 81ae812 Compare June 3, 2021 08:11
@AuHau AuHau marked this pull request as ready for review June 3, 2021 08:13
.github/workflows/beekeeper.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants