fix: marshal bigint as string #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this will most likely require changes to the beekeeper tests |
|
Yeah, you are right. I will try to make those adjustments, but not sure if I have sufficient knowledge for this 😅 |
|
I tried to put something here ethersphere/beekeeper#148 but not sure if it is working as I can't run it locally unfortunately. |
zelig
reviewed
Jun 3, 2021
There was a problem hiding this comment.
Reviewed 13 of 13 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AuHau)
AuHau
force-pushed
the
stringify-bigint
branch
2 times, most recently
from
72a91dc
to
81ae812
Compare
acud
approved these changes
Jun 9, 2021
istae
approved these changes
Jun 9, 2021
This was referenced Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1561 and closes #756.
It creates BigInt struct that is applied only to API layer, while all internal calculations are still kept in big.Int.
It introduces breaking changes for several DebugAPI endpoints where amounts are converted from numbers to strings.
Succeeds #1627
This change is