fix: add fallback content length check in middleware

[notanatol]

Checklist

• I have read the coding guide

Description

If decompressed-content-length fails try the normal one before stopping.

---

This change is 

[mrekucci]

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @acud)

---

pkg/api/api.go line 417 at r1 (raw file):

			case http.MethodGet:
				hdr := w.Header().Get("Decompressed-Content-Length")
				contentLength, err := strconv.Atoi(hdr)

There is no need to do the conversion if the header is not present. I'd recommend the following checks:

// ...
hdr := w.Header().Get("Decompressed-Content-Length")
if hdr == "" {
	s.logger.Debug("api: decompressed content length header not found")
	hdr = w.Header().Get("Content-Length")
	if hdr == "" {
		s.logger.Debug("api: content length header not found")
		return
	}
}
contentLength, err := strconv.Atoi(hdr)
if err != nil {
	s.logger.Debugf("api: content length: '%s', int conversion failed: %v", hdr, err)
	return
}
// ...

[notanatol]

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @acud)

---

pkg/api/api.go line 417 at r1 (raw file):

Previously, mrekucci wrote…

There is no need to do the conversion if the header is not present. I'd recommend the following checks:

// ...
hdr := w.Header().Get("Decompressed-Content-Length")
if hdr == "" {
	s.logger.Debug("api: decompressed content length header not found")
	hdr = w.Header().Get("Content-Length")
	if hdr == "" {
		s.logger.Debug("api: content length header not found")
		return
	}
}
contentLength, err := strconv.Atoi(hdr)
if err != nil {
	s.logger.Debugf("api: content length: '%s', int conversion failed: %v", hdr, err)
	return
}
// ...

replaced with this version