Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node start up to continue on bootstrapper error #2910

Merged
merged 2 commits into from Apr 27, 2022
Merged

fix: node start up to continue on bootstrapper error #2910

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b27814
fix: node start up to continue on bootstrapper error
istae Apr 27, 2022
ef0793a
fix: node start up to continue on bootstrapper error
istae Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/node/node.go
View file
Open in desktop
Expand Up @@ -479,9 +479,9 @@ func NewBee(addr string, publicKey *ecdsa.PublicKey, signer crypto.Signer, netwo
libp2pPrivateKey,
o,
)
logger.Infof("bootstrapper done, took %s", time.Since(start))
logger.Infof("bootstrapper took %s", time.Since(start))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be bootstrapper or BatchState initialization?

Copy link
Member

@agazso agazso Apr 28, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to agree that bootstrapper is hard to understand without context. My suggestion would be postage snapshot syncing took %s because that would be consistent how the feature is called in the config (use-postage-snapshot).

if err != nil {
return nil, fmt.Errorf("bootstrapper failed to fetch batch state: %w", err)
logger.Errorf("bootstrapper failed to fetch batch state: %w", err)
Copy link
Contributor

@mrekucci mrekucci Apr 27, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace %w with %v.

}
}

Expand Down