postage batch store #922
Closed
postage batch store #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zelig
force-pushed
the
batch-store
branch
3 times, most recently
from
7e9a8c8
to
62c2a5c
Compare
acud
force-pushed
the
storage-incentives
branch
2 times, most recently
from
134fa9a
to
cbd4d4a
Compare
zelig
force-pushed
the
storage-incentives
branch
from
cbd4d4a
to
97b2a15
Compare
| func (s *Store) settle(block uint64) { | ||
| period := int64(block - s.state.block) | ||
| s.state.block = block | ||
| s.state.total.Add(s.state.total, new(big.Int).Mul(s.state.price, big.NewInt(period))) |
There was a problem hiding this comment.
this reintroduces a lot of the reorg issues we wanted to get rid of. instead of doing this price update thing here we should refetch this value using the totalOutPayment getter when there is a PriceUpdate event on the oracle contract.
| if err != nil { | ||
| return err | ||
| } | ||
| b.Depth = depth |
There was a problem hiding this comment.
what is the unit of balance? is this total amount paid into it, or per chunk (like the normalised balance). If the latter, changing the depth also changes the balance.
zelig
commented
Dec 12, 2020
| return err | ||
| } | ||
| err = s.replace(id, b.Value, value) | ||
| value, err := s.balance(b, value) |
There was a problem hiding this comment.
value can cime durectly from the event]
| err = s.replace(id, b.Value, value) | ||
|
|
||
| panic("@zelig - should we have b.Add(value)?") | ||
| value, err := s.balance(b, value) |
There was a problem hiding this comment.
value can cime durectly from the event]
There was a problem hiding this comment.
we need the relace call bothg in topup and increasedepth
This was referenced Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecated by #1046. - based on AP #928 https://hackmd.io/o8RGsNwZSN6IE0lkBAZCPw