batch service #1046
batch service #1046
Conversation
| // event BatchCreated(bytes32 indexed batchId, uint256 initialBalance, address owner, uint256 depth); | ||
| type batchCreatedEvent struct { | ||
| batchID [32]byte | ||
| balance *big.Int |
| // event BatchTopUp(bytes32 indexed batchId, uint256 topupAmount); | ||
| type batchTopUpEvent struct { | ||
| batchID [32]byte | ||
| amount *big.Int |
| } | ||
|
|
||
| // event BatchCreated(bytes32 indexed batchId, uint256 initialBalance, address owner, uint256 depth); | ||
| type batchCreatedEvent struct { |
There was a problem hiding this comment.
event BatchCreated(bytes32 indexed batchId, uint256 totalAmount, uint256 normalisedBalance, address owner, uint8 depth);
event BatchTopUp(bytes32 indexed batchId, uint256 topupAmount, uint256 normalisedBalance);
event BatchDepthIncrease(bytes32 indexed batchId, uint8 newDepth, uint256 normalisedBalance);
event PriceUpdate(uint256 price, uint256 totalOutPayment)There was a problem hiding this comment.
in. genergal all nornalisedBalance -> Value
| ID []byte // batch ID | ||
| Value *big.Int // overall balance of the batch | ||
| Start uint64 // block number the batch was created | ||
| Owner []byte // owner's ethereum address |
There was a problem hiding this comment.
Should we use common.Address from go-ethereum here?
|
|
||
| // MarshalBinary serialises a postage batch to a byte slice len 117. | ||
| func (b *Batch) MarshalBinary() ([]byte, error) { | ||
| out := make([]byte, 93) |
There was a problem hiding this comment.
Should we declare some of these values as constants? Perhaps export them?
| ) | ||
|
|
||
| // Batch represents a postage batch, a payment on the blockchain. | ||
| type Batch struct { |
There was a problem hiding this comment.
Consider adding an Eq function to compare?
| if err := b.UnmarshalBinary(buf); err != nil { | ||
| t.Fatalf("unexpected error unmarshalling batch: %v", err) | ||
| } | ||
| if !bytes.Equal(b.ID, a.ID) { |
There was a problem hiding this comment.
We could use an Eq function here, see above.
| @@ -0,0 +1 @@ | |||
| package batchstore | |||
There was a problem hiding this comment.
File is empty, consider removing?
| func (s *Store) UnmarshalBinary(buf []byte) error { | ||
| s.block = binary.BigEndian.Uint64(buf[:8]) | ||
| totalLen := int(buf[8]) | ||
| if totalLen > math.MaxUint8 { |
| "github.com/ethersphere/bee/pkg/statestore/mock" | ||
| ) | ||
|
|
||
| func TestStore(t *testing.T) { |
| t.Fatal(err) | ||
| } | ||
| if store2.Price().Cmp(newPrice) != 0 { | ||
| t.Fatal("price not persisted") |
There was a problem hiding this comment.
Consider rewriting as price: got %v, want %v.
|
|
||
| expTotal := big.NewInt(0 + 99*1100) | ||
| if store2.Total().Cmp(expTotal) != 0 { | ||
| t.Fatal("value mismatch") |
There was a problem hiding this comment.
Consider rewriting as value: got %v, want %v.
| t.Fatal(err) | ||
| } | ||
|
|
||
| newPrice := big.NewInt(99) |
There was a problem hiding this comment.
Perhaps a line of comment as to what we are trying to achieve here? As in: creating the store, changing the price, expecting different result.
2 in 1 for better flexibility