Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci lint #80

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Ci lint #80

merged 1 commit into from
Aug 12, 2019

Conversation

ralph-pichler
Copy link
Member

@ralph-pichler ralph-pichler commented Aug 6, 2019

This PR runs the linters after the tests. It does so in the same job(?) as the test to avoid building the image twice and to avoid interacting with a registry.

@ralph-pichler ralph-pichler changed the base branch from master to simplest-swap August 6, 2019 11:08
@ralph-pichler ralph-pichler changed the base branch from simplest-swap to master August 6, 2019 11:16
@ralph-pichler ralph-pichler reopened this Aug 6, 2019
@ralph-pichler ralph-pichler marked this pull request as ready for review August 6, 2019 11:18
@Eknir
Copy link
Collaborator

Eknir commented Aug 7, 2019

Dependent on #78 to be pulled to master first

Copy link
Collaborator

@Eknir Eknir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ralph-pichler ralph-pichler merged commit 5ac9a42 into master Aug 12, 2019
@ralph-pichler ralph-pichler deleted the ci-lint branch August 12, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants