Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

network/retrieval: fix Price method reflect call #1765

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Conversation

janos
Copy link
Member

@janos janos commented Sep 17, 2019

This PR changes the RequestFromPeers Send to use RetrieveRequest pointer instead of value in order that the Price method correctly gets the type with reflection.

@janos janos self-assigned this Sep 17, 2019
@janos janos added this to Backlog in Swarm Core - Sprint planning via automation Sep 17, 2019
Copy link
Member

@ralph-pichler ralph-pichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janos janos merged commit 1456b9f into master Sep 17, 2019
Swarm Core - Sprint planning automation moved this from Backlog to Done Sep 17, 2019
@janos janos deleted the retrieval-price-fix branch September 17, 2019 14:01
@skylenet skylenet added this to the 0.5.0 milestone Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants