Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

stream: fix missing pointer in Send call #1770

Merged
merged 1 commit into from
Sep 17, 2019
Merged

stream: fix missing pointer in Send call #1770

merged 1 commit into from
Sep 17, 2019

Conversation

mortelli
Copy link
Contributor

@mortelli mortelli commented Sep 17, 2019

This PR is analogous to #1765; only it is applied to the stream protocol rather than the retrieve protocol.

  • the bug: there's a struct passed to a peer.Send call, which should be passed as a pointer instead of a plain struct
    • the call is made inside of the updateSyncSubscriptions function
    • the struct in question is the StreamInfoReq message
  • the bug was discovered while trying to implement accounting in the stream protocol
    • a reflect call with the purpose of adding price to the message will panic if the struct is passed as a value
    • accounting on top of the stream protocol might end up not being merged, but we should merge this fix anyways

@zelig zelig merged commit 5824b64 into master Sep 17, 2019
@skylenet skylenet added this to the 0.5.0 milestone Sep 18, 2019
@acud acud deleted the stream-pointer-fix branch September 23, 2019 10:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants