This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
cmd/swarm-smoke: add flag to bail on error #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
force-pushed
the
smoke-bail-on-err
branch
from
900676f
to
6b2eda6
Compare
janos
approved these changes
Sep 25, 2019
nonsense
approved these changes
Sep 26, 2019
nonsense
reviewed
Sep 26, 2019
| @@ -179,7 +183,7 @@ func trackChunks(testData []byte) error { | |||
| // addrs - a slice with all uploaded chunk refs | |||
| // allHostChunks - host->bit vector, showing what chunks are present on what hosts | |||
| // bzzAddrs - host->bzz address, used when determining the most proximate host for a given chunk | |||
| func checkChunksVsMostProxHosts(addrs []storage.Address, allHostChunks map[string]string, bzzAddrs map[string]string) { | |||
| func checkChunksVsMostProxHosts(addrs []storage.Address, allHostChunks map[string]string, bzzAddrs map[string]string) error { | |||
There was a problem hiding this comment.
@acud looks like this is no longer run for pushsync - it appears to be only called behind the flag syncDelay, and not behind pushsyncDelay.
There was a problem hiding this comment.
i fixed this @nonsense, please have a look at https://github.com/ethersphere/swarm/pull/1793/files#diff-4545af8f111f99eb44a69ef9b620c46fR311
acud
force-pushed
the
smoke-bail-on-err
branch
from
6b2eda6
to
b432e78
Compare
nonsense
approved these changes
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
--bailflag to the smoke test binary which tells the upload and sync test to bail on any intermediate errors found (such aschunk not found max proxandchunk at less than two hosts)fixes #1622